Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Bucket Tagging and Server-Side Encryption #86

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ykoer
Copy link

@ykoer ykoer commented Mar 2, 2021

I added support for turning objectbucketclaim labels to bucket tags and also a possibility to enable default S3 bucket encryption

objectbucketclaim with labels:

apiVersion: objectbucket.io/v1alpha1
kind: ObjectBucketClaim
metadata:
  name: myobc
  namespace: s3-provisioner
  labels:
    appcode: YOUR_APP_CODE
spec:
  storageClassName: s3-existing-buckets 

Annotated Storage Class to enable server-side encryption

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: s3-buckets
  annotations:
    aws-s3-server-side-default-encryption: "true"
provisioner: aws-s3.io/bucket
parameters:
  region: us-west-1
  secretName: s3-bucket-owner
  secretNamespace: s3-provisioner

Unfortunately, lib-bucket-provisioner is overwriting all the passed in labels with: bucket-provisioner=aws-s3.io-bucket
I had to patch it to merge all labels.

Let me know, if you have any questions

Thanks
Yusuf

@ykoer ykoer force-pushed the master branch 7 times, most recently from 2df3d6b to dab46fb Compare June 11, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant