CRISTAL-219: UI for creating pages #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add New Page dialog to the sidebar: `CPageCreationMenu` * Make navigation trees react to current page changes * Add prop to `XNavigationTree` to override default click action * Introduce `NavigationTreeSource.getParentNodesId()` * Introduce `WikiConfig.getPageResourceSeparator()` * Introduce `WikiConfig.getNewPageDefaultName()` * Introduce property `NavigationTreeNode.location` * Implement missing model on Shoelace's `XTextField` * Implement missing model on Shoelace's `XDialog` * Slightly unify CSS between Shoelace and Vuetify components * Update `vuetify` to version `3.6.15`
* Fix functional tests
manuelleduc
reviewed
Oct 1, 2024
manuelleduc
reviewed
Oct 1, 2024
* Remove `WikiConfig.getPageResourceSeparator()` * Revert vuetify upgrade * Other small improvements
* Change treeResolver to treeSource
mflorea
reviewed
Oct 2, 2024
core/navigation-tree/navigation-tree-xwiki/src/components/componentsInit.ts
Show resolved
Hide resolved
* Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/CRISTAL-219
Changes
Description
CPageCreationMenuXNavigationTreeto override default click actionNavigationTreeSource.getParentNodesId()WikiConfig.getPageResourceSeparator()WikiConfig.getNewPageDefaultName()NavigationTreeNode.locationXTextFieldXDialogvuetifyto version3.6.15Clarifications
The changes to the Navigation Tree will only work for the Nextcloud backend after this PR is merged.
vuetifywas updated to the last iteration of3.6.xin order to fix some bugs withVTreeview. Updating to3.7.xwill need to be postponed until vuetifyjs/vuetify#20460 is resolved.Screenshots & Video
Shoelace
Vuetify
Executed Tests
Everything was tested manually and the test suite was run succesfully.
Expected merging strategy