Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename member management functions #867

Merged
merged 2 commits into from
Mar 11, 2025
+8 −8
Merged

Rename member management functions #867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1217bb0
Rename member mgmt functions
rygine Mar 11, 2025
82c8c19
Update tests
rygine Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdks/node-sdk/src/Group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,19 +81,19 @@ export class Group extends Conversation {
return this.#conversation.isSuperAdmin(inboxId);
}

async addMembers(identifiers: Identifier[]) {
async addMembersByIdentifiers(identifiers: Identifier[]) {
return this.#conversation.addMembers(identifiers);
}

async addMembersByInboxId(inboxIds: string[]) {
async addMembers(inboxIds: string[]) {
return this.#conversation.addMembersByInboxId(inboxIds);
}

async removeMembers(identifiers: Identifier[]) {
async removeMembersByIdentifiers(identifiers: Identifier[]) {
return this.#conversation.removeMembers(identifiers);
}

async removeMembersByInboxId(inboxIds: string[]) {
async removeMembers(inboxIds: string[]) {
return this.#conversation.removeMembersByInboxId(inboxIds);
}

Expand Down
8 changes: 4 additions & 4 deletions sdks/node-sdk/test/Conversation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ describe.concurrent("Conversation", () => {
expect(memberInboxIds).toContain(client2.inboxId);
expect(memberInboxIds).not.toContain(client3.inboxId);

await conversation.addMembers([await signer3.getIdentifier()]);
await conversation.addMembers([client3.inboxId]);

const members2 = await conversation.members();
expect(members2.length).toBe(3);
Expand All @@ -134,7 +134,7 @@ describe.concurrent("Conversation", () => {
expect(memberInboxIds2).toContain(client2.inboxId);
expect(memberInboxIds2).toContain(client3.inboxId);

await conversation.removeMembers([await signer2.getIdentifier()]);
await conversation.removeMembers([client2.inboxId]);

const members3 = await conversation.members();
expect(members3.length).toBe(2);
Expand Down Expand Up @@ -165,7 +165,7 @@ describe.concurrent("Conversation", () => {
expect(memberInboxIds).toContain(client2.inboxId);
expect(memberInboxIds).not.toContain(client3.inboxId);

await conversation.addMembersByInboxId([client3.inboxId]);
await conversation.addMembers([client3.inboxId]);

const members2 = await conversation.members();
expect(members2.length).toBe(3);
Expand All @@ -175,7 +175,7 @@ describe.concurrent("Conversation", () => {
expect(memberInboxIds2).toContain(client2.inboxId);
expect(memberInboxIds2).toContain(client3.inboxId);

await conversation.removeMembersByInboxId([client2.inboxId]);
await conversation.removeMembers([client2.inboxId]);

const members3 = await conversation.members();
expect(members3.length).toBe(2);
Expand Down
Loading