Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to a V3 only SDK #312

Merged
merged 15 commits into from
Nov 7, 2024
Merged

Update to a V3 only SDK #312

merged 15 commits into from
Nov 7, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Nov 3, 2024

First PR in a stack of PRs to remove all V1 and V2 functionality from the codebase.

@nplasterer nplasterer self-assigned this Nov 3, 2024
@nplasterer nplasterer changed the title Remove V1 & V2 Conversations [V3] Remove V1 & V2 Conversations Nov 3, 2024
@nplasterer nplasterer marked this pull request as ready for review November 6, 2024 17:33
@nplasterer nplasterer requested a review from a team as a code owner November 6, 2024 17:33
Copy link
Contributor

@codabrink codabrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup 🎉

* remove decrypted messages and only use decoded

* [V3] Remove contacts and rename to preferences (#314)

* remove contacts and rename to preferences

* [V3] Remove the ability to create a V2 client (#315)

* remove the ability to create a v2 client entirely

* remove a bunch of classes no longer needed

* [V3] Fix up all the tests (#316)

* get all the tests compiling

* fix up the wallet address

* more clean up

* get all the tests passing

* make the ffiClient private so people dont call it directly

* [V3] Update example app (#317)

* update the example to be v3 only

* remove force

* remove some impots

* update frames

* clean up the code

* rename and fix up the lint
@nplasterer nplasterer changed the title [V3] Remove V1 & V2 Conversations Update to a V3 only SDK Nov 7, 2024
@nplasterer nplasterer requested a review from a team as a code owner November 7, 2024 02:43
@nplasterer
Copy link
Contributor Author

All tests are green

Screenshot 2024-11-06 at 6 54 05 PM

@nplasterer
Copy link
Contributor Author

Screenshot 2024-11-06 at 6 55 40 PM

Example works with Dms and Groups

@nplasterer nplasterer merged commit 9b9f628 into main Nov 7, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/v3 branch November 7, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants