Remove defunct protos #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhuaaa
commented
Sep 3, 2024
neekolas
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Thanks for tackling. Think this checks off a few boxes in Phase 2 of this issue
|
Ah, I totally missed that you were on it! Sorry for pre-empting you |
neekolas
approved these changes
Sep 4, 2024
|
🎉 This PR is included in version 3.67.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
richardhuaaa
added a commit
to xmtp/libxmtp
that referenced
this pull request
Sep 4, 2024
This is a follow-on to xmtp/proto#202, to remove defunct code that may cause confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bunch of defunct code on both client and server I want to clean up - this should be helpful for new hires, backwards-compatibility for the replication project, debugging, and auditability. Starting with the protos first