Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to reflect change from address to inboxIds #149

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Update docs to reflect change from address to inboxIds #149

wants to merge 42 commits into from

Conversation

jhaaaa
Copy link
Collaborator

@jhaaaa jhaaaa commented Mar 6, 2025

No description provided.

@jhaaaa jhaaaa requested a review from a team as a code owner March 6, 2025 02:26
@vercel Vercel
Copy link

vercel bot commented Mar 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-xmtp-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 10:32pm

@jhaaaa jhaaaa marked this pull request as draft March 6, 2025 02:29
nplasterer
nplasterer reviewed Mar 6, 2025
View reviewed changes
docs/pages/inboxes/user-consent/support-user-consent.md Outdated
To identify contacts the user might know or want to know, you can look for signals in onchain data that imply an affinity between addresses. You can then display appropriate messages on a **You might know** tab, for example.
jhaaa for identities that don't have addresses -- what kind of onchain data signals can devs use?

To identify contacts the user might know or want to know, you can look for signals in onchain data that imply an affinity between addresses. You can then display appropriate messages on a **You might know** tab, for example.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

val inboxState = inboxStateForInboxId(inboxId)
val identities = inboxState.identities
val ethAddresses = identities
    .filter { it.kind == ETHEREUM }
    .map { it.identifier }

@jhaaaa jhaaaa marked this pull request as ready for review March 6, 2025 23:55
@jhaaaa jhaaaa changed the title Update docs to reflect change from address to identities and inboxIds Update docs to reflect change from address to inboxIds Mar 7, 2025
jhaaaa
jhaaaa commented Mar 8, 2025
View reviewed changes
jhaaaa
jhaaaa commented Mar 11, 2025
View reviewed changes
jhaaaa
jhaaaa commented Mar 11, 2025
View reviewed changes
nplasterer
nplasterer approved these changes Mar 11, 2025
View reviewed changes
docs/pages/inboxes/group-permissions.mdx
Comment on lines -330 to -354
### Add members by address

:::code-group

```js [Browser]
await group.addMembers([walletAddress]);
```

```js [Node]
await group.addMembers([walletAddress]);
```

```tsx [React Native]
await group.addMembers([walletAddress]);
```

```kotlin [Kotlin]
group.addMembers(listOf(walletAddress))
```

```swift [Swift]
try await group.addMembers(addresses: [walletAddress])
```

:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably keep this section if you but just put it at the bottom for doing it by identity

await group.addMembersByIdentity([identity]);

etc...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do this we may want to add the newGroup and newDm methods as well that take and Identity 🤷

jhaaaa and others added 7 commits March 11, 2025 14:58
jhaaaa and others added 2 commits March 11, 2025 15:04
jhaaaa and others added 2 commits March 11, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaaaa @nplasterer