Do not silently swallow exceptions while parsing #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
this is a tiny PR to remove ambiguity during parsing. Right now, it's impossible to know whether parsing failed or a character/fc/etc was not found. If the entity was not found, the method returns null. However, the method also returns null if certain exceptions were thrown.
I believe there is no reason to swallow exceptions at this point and it would be better practice to throw them instead. It's up to the user to handle the exceptions appropriately. This makes errors more transparent when using the parser, and removes the ambiguity between entity not found / parsing failed. It also allows setup of resilience pipelines to retry parsing in case of network/rate limit issues.