chore(deps): update actions/checkout action to v4 #4600
clippy
28 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 28 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.0 (5680fa18f 2023-08-23)
- cargo 1.72.0 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (5680fa1 2023-08-23)
Annotations
Check failure on line 214 in src/api/color.rs
github-actions / clippy
useless use of `vec!`
error: useless use of `vec!`
--> src/api/color.rs:214:3
|
214 | ArgEnum,
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: this error originates in the derive macro `ArgEnum` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 48 in src/api/color.rs
github-actions / clippy
useless use of `vec!`
error: useless use of `vec!`
--> src/api/color.rs:48:3
|
48 | ArgEnum,
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: this error originates in the derive macro `ArgEnum` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 107 in src/encoder.rs
github-actions / clippy
useless use of `vec!`
error: useless use of `vec!`
--> src/encoder.rs:107:3
|
107 | ArgEnum, Copy, Clone, Debug, PartialEq, Eq, Serialize, Deserialize, Default,
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: this error originates in the derive macro `ArgEnum` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 378 in src/partition.rs
github-actions / clippy
docs for function which may panic missing `# Panics` section
error: docs for function which may panic missing `# Panics` section
--> src/partition.rs:378:3
|
378 | pub fn largest_chroma_tx_size(self, xdec: usize, ydec: usize) -> TxSize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/partition.rs:379:23
|
379 | let plane_bsize = self
| _______________________^
380 | | .subsampled_size(xdec, ydec)
381 | | .expect("invalid block size for this subsampling mode");
| |_____________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
= note: `-D clippy::missing-panics-doc` implied by `-D warnings`
Check failure on line 104 in src/asm/x86/cdef.rs
github-actions / clippy
casting raw pointers to the same type and constness is unnecessary (`*const u16` -> `*const u16`)
error: casting raw pointers to the same type and constness is unnecessary (`*const u16` -> `*const u16`)
--> src/asm/x86/cdef.rs:104:15
|
104 | tmp.data.as_ptr().offset(3 * TMPSTRIDE) as *const u16,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tmp.data.as_ptr().offset(3 * TMPSTRIDE)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
Check failure on line 14 in src/cpu_features/x86.rs
github-actions / clippy
useless use of `vec!`
error: useless use of `vec!`
--> src/cpu_features/x86.rs:14:57
|
14 | #[derive(Debug, Copy, Clone, PartialEq, Eq, PartialOrd, ArgEnum)]
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `-D clippy::useless-vec` implied by `-D warnings`
= note: this error originates in the derive macro `ArgEnum` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/transform/inverse.rs:429:1
|
429 | / cpu_function_lookup_table!(
430 | | INV_TXFM_HBD_FNS_12: [[[Option<InvTxfmHBDFunc>; TX_TYPES]; 32]],
431 | | default: [[None; TX_TYPES]; 32],
432 | | [AVX2]
433 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/transform/inverse.rs:391:1
|
391 | / cpu_function_lookup_table!(
392 | | INV_TXFM_HBD_FNS_10: [[[Option<InvTxfmHBDFunc>; TX_TYPES]; 32]],
393 | | default: [[None; TX_TYPES]; 32],
394 | | [SSE4_1, AVX2, AVX512ICL]
395 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/transform/inverse.rs:252:1
|
252 | / cpu_function_lookup_table!(
253 | | INV_TXFM_FNS: [[[Option<InvTxfmFunc>; TX_TYPES]; 32]],
254 | | default: [[None; TX_TYPES]; 32],
255 | | [SSSE3, AVX2, AVX512ICL]
256 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 139 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:139:32
|
139 | cpu_function_lookup_table!(pub(self), $name: [$type], default: $empty, [$(($key, $value)),*]);
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/quantize.rs:32:1
|
32 | / cpu_function_lookup_table!(
33 | | DEQUANTIZE_FNS: [Option<DequantizeFn>],
34 | | default: None,
35 | | [(AVX2, Some(dequantize_avx2))]
36 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 139 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:139:32
|
139 | cpu_function_lookup_table!(pub(self), $name: [$type], default: $empty, [$(($key, $value)),*]);
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/mc.rs:618:1
|
618 | / cpu_function_lookup_table!(
619 | | AVG_HBD_FNS: [Option<AvgHBDFn>],
620 | | default: None,
621 | | [(SSSE3, Some(rav1e_avg_16bpc_ssse3)), (AVX2, Some(rav1e_avg_16bpc_avx2))]
622 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 139 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:139:32
|
139 | cpu_function_lookup_table!(pub(self), $name: [$type], default: $empty, [$(($key, $value)),*]);
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/mc.rs:608:1
|
608 | / cpu_function_lookup_table!(
609 | | AVG_FNS: [Option<AvgFn>],
610 | | default: None,
611 | | [
... |
615 | | ]
616 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/mc.rs:575:1
|
575 | / cpu_function_lookup_table!(
576 | | PREP_HBD_FNS: [[Option<PrepHBDFn>; 16]],
577 | | default: [None; 16],
578 | | [SSSE3, AVX2]
579 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/mc.rs:520:1
|
520 | / cpu_function_lookup_table!(
521 | | PREP_FNS: [[Option<PrepFn>; 16]],
522 | | default: [None; 16],
523 | | [SSE2, SSSE3, AVX2, AVX512ICL]
524 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/mc.rs:439:1
|
439 | / cpu_function_lookup_table!(
440 | | PUT_HBD_FNS: [[Option<PutHBDFn>; 16]],
441 | | default: [None; 16],
442 | | [SSSE3, AVX2]
443 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/mc.rs:384:1
|
384 | / cpu_function_lookup_table!(
385 | | PUT_FNS: [[Option<PutFn>; 16]],
386 | | default: [None; 16],
387 | | [SSSE3, AVX2, AVX512ICL]
388 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/dist/mod.rs:725:1
|
725 | / cpu_function_lookup_table!(
726 | | SATD_HBD_FNS: [[Option<SatdHBDFn>; DIST_FNS_LENGTH]],
727 | | default: [None; DIST_FNS_LENGTH],
728 | | [AVX2]
729 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/dist/mod.rs:686:1
|
686 | / cpu_function_lookup_table!(
687 | | SATD_FNS: [[Option<SatdFn>; DIST_FNS_LENGTH]],
688 | | default: [None; DIST_FNS_LENGTH],
689 | | [SSSE3, SSE4_1, AVX2]
690 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/dist/mod.rs:626:1
|
626 | / cpu_function_lookup_table!(
627 | | SAD_HBD_FNS: [[Option<SadHBDFn>; DIST_FNS_LENGTH]],
628 | | default: [None; DIST_FNS_LENGTH],
629 | | [SSSE3, AVX2]
630 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/dist/mod.rs:555:1
|
555 | / cpu_function_lookup_table!(
556 | | SAD_FNS: [[Option<SadFn>; DIST_FNS_LENGTH]],
557 | | default: [None; DIST_FNS_LENGTH],
558 | | [SSE2, AVX2]
559 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/dist/sse.rs:220:1
|
220 | / cpu_function_lookup_table!(
221 | | SSE_HBD_FNS: [[Option<WeightedSseHBDFn>; DIST_FNS_LENGTH]],
222 | | default: [None; DIST_FNS_LENGTH],
223 | | [SSE2]
224 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/dist/sse.rs:214:1
|
214 | / cpu_function_lookup_table!(
215 | | SSE_FNS: [[Option<WeightedSseFn>; DIST_FNS_LENGTH]],
216 | | default: [None; DIST_FNS_LENGTH],
217 | | [SSSE3, AVX2]
218 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/dist/cdef_dist.rs:238:1
|
238 | / cpu_function_lookup_table!(
239 | | CDEF_DIST_KERNEL_HBD_FNS:
240 | | [[Option<CdefDistKernelHBDFn>; CDEF_DIST_KERNEL_FNS_LENGTH]],
241 | | default: [None; CDEF_DIST_KERNEL_FNS_LENGTH],
242 | | [AVX2]
243 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 154 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:154:7
|
154 | pub(self), $name: [$type], default: $empty, [$($key),*]
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/dist/cdef_dist.rs:146:1
|
146 | / cpu_function_lookup_table!(
147 | | CDEF_DIST_KERNEL_FNS:
148 | | [[Option<CdefDistKernelFn>; CDEF_DIST_KERNEL_FNS_LENGTH]],
149 | | default: [None; CDEF_DIST_KERNEL_FNS_LENGTH],
150 | | [SSE2]
151 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)
Check failure on line 139 in src/cpu_features/x86.rs
github-actions / clippy
unnecessary `pub(self)`
error: unnecessary `pub(self)`
--> src/cpu_features/x86.rs:139:32
|
139 | cpu_function_lookup_table!(pub(self), $name: [$type], default: $empty, [$(($key, $value)),*]);
| ^^^^^^^^^ help: remove it
|
::: src/asm/x86/cdef.rs:282:1
|
282 | / cpu_function_lookup_table!(
283 | | CDEF_DIR_HBD_FNS: [Option<CdefDirHBDFn>],
284 | | default: None,
285 | | [
... |
289 | | ]
290 | | );
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: this error originates in the macro `cpu_function_lookup_table` (in Nightly builds, run with -Z macro-backtrace for more info)