Drop binary integration test from coverage
#3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
force-pushed
the
exclude-binary-tests-from-coverage
branch
from
ece2397
to
38711ad
Compare
|
Had to include a clippy fix so the job actually runs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3398 +/- ##
==========================================
- Coverage 88.52% 82.14% -6.39%
==========================================
Files 89 89
Lines 28323 27408 -915
==========================================
- Hits 25074 22515 -2559
- Misses 3249 4893 +1644 ☔ View full report in Codecov by Sentry. |
FreezyLemon
force-pushed
the
exclude-binary-tests-from-coverage
branch
2 times, most recently
from
c3bf888
to
391b452
Compare
It causes problems and makes no sense to collect anyways because it just calls precompiled binaries from rust code. We now need two calls to `cargo test` because `--doc` can not be combined with any other testing target.
This is a `u8` which has a max value of 255
FreezyLemon
force-pushed
the
exclude-binary-tests-from-coverage
branch
from
391b452
to
a1bfdd0
Compare
lu-zero
approved these changes
Sep 14, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3394.