Avoid returning the InvoiceID of the first Payment for áll the returned Payments w/ using gateway.get_payments #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hiya @jomz, thanks for the PR! Given that the 1.8 series of Ruby was retired quite some time ago I don't think we want to continue to support it - at this point it's potentially dangerous to do so, given security patches will not be produced. The PR is a great bug fix, but could we have it without the 1.8 changes? If you still require 1.8 support for a legacy project, then I'd be happy to maintain a "1.8" branch on Github carrying a suitable warning in the README.md 😄 |
|
Roger! Cleaned up pull request here: #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XPaths used ("//SomeElement") made any node within the response match, but you only want to match from the child nodes...
Test included.
Sorry for also including my previous commit f68b950, just let me know if you want me to send a cleaner PR..