fix: change filtering logic to not include nested property elements (#…

…756)

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.24.3]
+
+- Fox for broken property traversal #755
+
 ## [1.24.2]
 
 - Additional fix for extended root property in eval #751

src/xdebugConnection.ts

@@ -571,9 +571,9 @@ export class Property extends BaseProperty {
         }
         this.context = context
         if (this.hasChildren) {
-            this.children = Array.from((<Element>propertyNode).getElementsByTagName('property')).map(
-                (propertyNode: Element) => new Property(propertyNode, context)
-            )
+            this.children = Array.from(propertyNode.childNodes)
+                .filter(node => node.nodeName === 'property')
+                .map((propertyNode: Element) => new Property(propertyNode, context))
         }
     }
 
@@ -644,9 +644,9 @@ export class PropertyGetResponse extends Response {
      */
     constructor(document: XMLDocument, context: Context) {
         super(document, context.stackFrame.connection)
-        this.children = Array.from(
-            (<Element>document.documentElement.firstChild!).getElementsByTagName('property')
-        ).map((propertyNode: Element) => new Property(propertyNode, context))
+        this.children = Array.from(document.documentElement.firstChild!.childNodes)
+            .filter(node => node.nodeName === 'property')
+            .map((propertyNode: Element) => new Property(propertyNode, context))
     }
 }
 
@@ -670,9 +670,9 @@ export class EvalResultProperty extends BaseProperty {
     constructor(propertyNode: Element) {
         super(propertyNode)
         if (this.hasChildren) {
-            this.children = Array.from(propertyNode.getElementsByTagName('property')).map(
-                (propertyNode: Element) => new EvalResultProperty(propertyNode)
-            )
+            this.children = Array.from(propertyNode.childNodes)
+                .filter(node => node.nodeName === 'property')
+                .map((propertyNode: Element) => new EvalResultProperty(propertyNode))
         }
     }
 }