Rework strategy to select/deselect items #1237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
improve_actionsheet
branch
2 times, most recently
from
ae9a40e to
d0044d0
Compare
wutschel
changed the title
wutschel
force-pushed
the
improve_actionsheet
branch
2 times, most recently
from
4e7fdbb to
b8b6069
Compare
|
@kambala-decapitator, based on your last message I switched the selection logic with commit "all reworked" to
|
|
from the diff I don't see any obvious issues. The main point is whether UX on iPad improved or not :) |
|
I am fine going with the way you proposed. It is better and more consistent to what we had before. In case we get different feedback we can anyway revise this again. So, I will update this now and rebase it. Will be done in 10 mins. |
This unifies behaviour between iPad and iPhone.
Remove selection when showing an action sheet. The details for the selected item are anyway shown on top of the action sheet, and on iPad there is a pointer to the touched origin. At the same time select an item on tap and keep it selected when entering a next level view. This visually emphasizes the selected item when showing two view side-by-side as it is done on iPad.
The 2nd animated call of deselectRowAtIndexPath is obsolete. Indentation is corrected as well.
wutschel
force-pushed
the
improve_actionsheet
branch
from
c85eb9d to
ff6ac96
Compare
|
Updated code, PR description and rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR is motivated by a discussion in this forum post.
This PR unifies the selection/deselection behaviour for iPad and iPhone by not setting
in iPad's StackViewController. This is not required as sliding the views is not impacted, but an unwanted side effect of non-visible selections is gone.
Generally this PR reworks the strategy to show the selection of items. The selection is removed when showing an action sheet. The details for the selected item are anyway shown on top of the action sheet, on iPad there is a pointer to the touched origin and on iPhone the selection is most cases hidden behind the action sheet. Now, a selection is shown on tap and kept when entering a next level view, e.g. selecting a movie and entering the movie details. This visually emphasizes the selected item when showing two views side-by-side as it is done on iPad.
Summary for release notes
Improvement: Unify selection/deselection for iPad/iPhone