Opt-out from deprecations about future return types

Adding actual return types might be a BC break for child classes, but must be done before supporting Symfony 6
xabbuh · Oct 14, 2021 · 2206c78 · 2206c78
1 parent 3719a56
commit 2206c78
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 0 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,6 +23,9 @@ jobs:
         name: "Tests on PHP ${{ matrix.php }}${{ matrix.name_suffix }}"
         runs-on: ubuntu-latest
 
+        env:
+            SYMFONY_DEPRECATIONS_HELPER: 'max[direct]=0' # TODO remove that once upgrading dev-deps job to run on PHPUnit 9.5 on PHP 8
+
         strategy:
             fail-fast: false
             matrix:

diff --git a/Command/CloudCommand.php b/Command/CloudCommand.php
@@ -91,6 +91,8 @@ abstract protected function doExecuteCommand(InputInterface $input, OutputInterf
 
     /**
      * {@inheritDoc}
+     *
+     * @return int
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {

diff --git a/Command/ModifyCloudCommand.php b/Command/ModifyCloudCommand.php
@@ -66,6 +66,8 @@ protected function configure()
 
     /**
      * {@inheritDoc}
+     *
+     * @return int
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {

diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -23,6 +23,8 @@ class Configuration implements ConfigurationInterface
 {
     /**
      * {@inheritDoc}
+     *
+     * @return TreeBuilder
      */
     public function getConfigTreeBuilder()
     {

diff --git a/DependencyInjection/XabbuhPandaExtension.php b/DependencyInjection/XabbuhPandaExtension.php
@@ -158,6 +158,8 @@ private function loadClouds(array $clouds, ContainerBuilder $container, array $k
 
     /**
      * {@inheritDoc}
+     *
+     * @return string
      */
     public function getNamespace()
     {
-Original file line number
+Diff line change
@@ Expand Up @@
         /**
          * {@inheritDoc}
+         *
+         * @return int
          */
         protected function execute(InputInterface $input, OutputInterface $output)
         {
@@ Expand Down @@