Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New @wxt-dev/analytics package #790

Merged
merged 53 commits into from
Mar 4, 2025
Merged

feat: New @wxt-dev/analytics package #790

merged 53 commits into from
Mar 4, 2025

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Jul 2, 2024

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 1b54299
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67c68396f8e7c100080ebf8f
😎 Deploy Preview https://deploy-preview-790--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title feat: Analytics module feat: New @wxt-dev/analytics package Jul 3, 2024
@aklinker1
Copy link
Collaborator Author

Alright, the app config resolution error has been solved, but new error popped up.

The analytics export isn't a singleton during development. Sometimes it uses the optimized dependency inside node_modules/.vite/deps/@wxt-dev/analytics and sometimes the non-optimized dependency node_modules/@wxt-dev/analytics...

Tried excluding @wxt-dev/analytics from optimization, but that didn't work. Never delt with this before with Vite, so I don't have an immediate solution...

@aklinker1 aklinker1 added this to the v1.0 milestone Aug 16, 2024
@aklinker1 aklinker1 mentioned this pull request Aug 16, 2024
30 tasks
@aklinker1 aklinker1 self-assigned this Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.17%. Comparing base (78f97f3) to head (1509809).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
+ Coverage   81.12%   81.17%   +0.04%     
==========================================
  Files         128      128              
  Lines        6285     6285              
  Branches     1071     1070       -1     
==========================================
+ Hits         5099     5102       +3     
+ Misses       1171     1168       -3     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review December 30, 2024 02:35
@aklinker1
Copy link
Collaborator Author

aklinker1 commented Dec 30, 2024

Alright, this is ready to be released. Will be releasing it as v0.4.0 until some more people have tried it out and have validated the API design.

Copy link

pkg-pr-new bot commented Dec 30, 2024

Open in Stackblitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@790

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@790

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@790

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@790

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@790

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@790

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@790

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@790

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@790

wxt

npm i https://pkg.pr.new/wxt@790

commit: 1b54299

@aklinker1 aklinker1 marked this pull request as draft December 30, 2024 14:04
@aklinker1 aklinker1 marked this pull request as ready for review January 5, 2025 16:35
@aklinker1
Copy link
Collaborator Author

Gonna wait for #1085 to merge.

@aklinker1 aklinker1 requested a review from Timeraa as a code owner February 13, 2025 04:40
@aklinker1
Copy link
Collaborator Author

Gonna wait for #1085 to merge.

Nope, I'm gonna merge this. PR has been open for too long, and last I checked, the module worked great. So no reason to wait.

@aklinker1 aklinker1 merged commit 0f0daf3 into main Mar 4, 2025
16 checks passed
@aklinker1 aklinker1 deleted the analytics-module branch March 4, 2025 04:44
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant