-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for in-memory claim management #21601
base: master
Are you sure you want to change the base?
Conversation
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 suggestion.
Files not reviewed (5)
- modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/claim/management/v1/claim-management-add-external-claim-already-mapped.json: Language not supported
- modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/claim/management/v1/claim-management-add-external-claim-mapped-to-custom-local-claim.json: Language not supported
- modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/claim/management/v1/claim-management-add-local-claim-with-existing-uri.json: Language not supported
- modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/claim/management/v1/claim-management-update-external-claim-already-mapped.json: Language not supported
- modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/claim/management/v1/claim-management-update-external-claim-invalid-mapped-claim.json: Language not supported
Comments skipped due to low confidence (1)
modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/restclients/ClaimManagementRestClient.java:121
- The error message 'External claim update failed' is not descriptive enough. It should include the 'dialectId' and 'claimId' to provide more context.
Assert.assertEquals(response.getStatusLine().getStatusCode(), HttpServletResponse.SC_OK, "External claim update failed");
...entity/integration/test/rest/api/server/claim/management/v1/ClaimManagementNegativeTest.java
Outdated
Show resolved
Hide resolved
67508bc
to
17b365a
Compare
17b365a
to
08e3fa2
Compare
PR builder started |
PR builder completed |
08e3fa2
to
8afb650
Compare
PR builder started |
PR builder completed |
Purpose
$subject
Related PRs