Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for event subscription flows in PostgreSQL #97

Merged
merged 10 commits into from
Aug 6, 2024
Merged

Bug fixes for event subscription flows in PostgreSQL #97

merged 10 commits into from
Aug 6, 2024

Conversation

anjuchamantha
Copy link
Contributor

Bug fixes for event subscription flows in PostgreSQL

This PR fixes bugs in event subscription in PostgreSQL for the following flows

  1. Create event notification subscription
  2. Retrieve an Event Notification Subscription
  3. Retrieve All Event Notification Subscriptions
  4. Retrieve Event Notification Subscriptions by an Subscribed Event Type
  5. Update an Event Notification Subscription
  6. Delete an Event Notification Subscription

Issue link: required

Applicable Labels: OB3 Accelerator

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

Ashi1993
Ashi1993 reviewed Aug 5, 2024
View reviewed changes
.../openbanking/accelerator/event/notifications/service/dao/EventSubscriptionSqlStatements.java Outdated
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2023, WSO2 LLC. (https://www.wso2.com).
* Copyright (c) 2024, WSO2 LLC. (https://www.wso2.com).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thus should be 2023-2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 1314cee

Ashi1993
Ashi1993 reviewed Aug 5, 2024
View reviewed changes
...s/com.wso2.openbanking.accelerator.event.notifications.service/src/test/resources/testng.xml Outdated
@@ -1,5 +1,5 @@
<!--
~ Copyright (c) 2023, WSO2 LLC. (https://www.wso2.com).
~ Copyright (c) 2024, WSO2 LLC. (https://www.wso2.com).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 2023-2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 1314cee

@Ashi1993 Ashi1993 merged commit efb096c into wso2:main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akila94 Akila94 Akila94 approved these changes

@Ashi1993 Ashi1993 Ashi1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anjuchamantha @Ashi1993 @Akila94