Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRP consent initiation flow implementation #37

Merged
merged 35 commits into from
Feb 16, 2024
Merged

VRP consent initiation flow implementation #37

merged 35 commits into from
Feb 16, 2024

Conversation

kalpanakanagasabai
Copy link
Contributor

@kalpanakanagasabai kalpanakanagasabai commented Nov 24, 2023 •
edited
Loading

VRP consent initiation flow implementation

This PR contains the implementation to implement implementing the common features of variable recurring payment API in the Open Banking Accelerator with the capability to extend the implementation to the Toolkits.

Issue link: #36

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: OB Accelerator

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

VimukthiRajapaksha
VimukthiRajapaksha reviewed Dec 18, 2023
View reviewed changes
...erator.common/src/main/java/com/wso2/openbanking/accelerator/common/util/ErrorConstants.java Outdated Show resolved Hide resolved
...erator.common/src/main/java/com/wso2/openbanking/accelerator/common/util/ErrorConstants.java Outdated Show resolved Hide resolved
...erator.common/src/main/java/com/wso2/openbanking/accelerator/common/util/ErrorConstants.java Outdated Show resolved Hide resolved
...erator.common/src/main/java/com/wso2/openbanking/accelerator/common/util/ErrorConstants.java Outdated Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Outdated Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Outdated Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Outdated Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Outdated Show resolved Hide resolved
VimukthiRajapaksha
VimukthiRajapaksha reviewed Dec 18, 2023
View reviewed changes
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Outdated Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Outdated Show resolved Hide resolved
...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java
ConsentExtensionConstants.VRP));
consentManageData.setResponseStatus(ResponseStatus.OK);
} catch (ConsentManagementException | ParseException e) {
throw new ConsentException(ResponseStatus.INTERNAL_SERVER_ERROR,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to log the exception here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in [a575078]

...om/wso2/openbanking/accelerator/consent/extensions/manage/impl/VRPConsentRequestHandler.java Outdated Show resolved Hide resolved
.../openbanking/accelerator/consent/extensions/manage/validator/VRPConsentRequestValidator.java Outdated Show resolved Hide resolved
.../openbanking/accelerator/consent/extensions/manage/validator/VRPConsentRequestValidator.java Outdated Show resolved Hide resolved
.../openbanking/accelerator/consent/extensions/manage/validator/VRPConsentRequestValidator.java Outdated Show resolved Hide resolved
.../openbanking/accelerator/consent/extensions/manage/validator/VRPConsentRequestValidator.java Outdated Show resolved Hide resolved
.../openbanking/accelerator/consent/extensions/manage/validator/VRPConsentRequestValidator.java Outdated Show resolved Hide resolved
@hasithakn hasithakn merged commit 00f20d3 into wso2:main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RivinduM RivinduM RivinduM left review comments

@VimukthiRajapaksha VimukthiRajapaksha VimukthiRajapaksha left review comments

@hasithakn hasithakn hasithakn approved these changes

@Ashi1993 Ashi1993 Ashi1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kalpanakanagasabai @CLAassistant @Ashi1993 @VimukthiRajapaksha @RivinduM @hasithakn