Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue of PAR response returning wrong error code when mandatory params not present in the client assertion #197

Open
wants to merge 1 commit into
base: 3.0.0
Choose a base branch
from
Open

Fix issue of PAR response returning wrong error code when mandatory params not present in the client assertion #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions ...o2/openbanking/accelerator/push/authorization/endpoint/api/PushAuthorisationEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,6 @@ public Response parPost(@Context HttpServletRequest request, @Context HttpServle
OAuthClientAuthnContext clientAuthnContext = (OAuthClientAuthnContext)
request.getAttribute(CLIENT_AUTHENTICATION_CONTEXT);

// Check if the client authentication is successful
if (!clientAuthnContext.isAuthenticated()) {
// create error response
PushAuthErrorResponse errorResponse = pushAuthRequestValidator
.createErrorResponse(HttpServletResponse.SC_UNAUTHORIZED,
clientAuthnContext.getErrorCode(), clientAuthnContext.getErrorMessage());
return Response.status(errorResponse.getHttpStatusCode())
.entity(errorResponse.getPayload()).build();
}

try {
paramMap = pushAuthRequestValidator.validateParams(request, (Map<String, List<String>>) parameterMap);
} catch (PushAuthRequestValidatorException exception) {
Expand All @@ -113,7 +103,17 @@ public Response parPost(@Context HttpServletRequest request, @Context HttpServle
.createErrorResponse(exception.getHttpStatusCode(), exception.getErrorCode(),
exception.getErrorDescription());
return Response.status(errorResponse.getHttpStatusCode() != 0 ?
errorResponse.getHttpStatusCode() : exception.getHttpStatusCode())
errorResponse.getHttpStatusCode() : exception.getHttpStatusCode())
.entity(errorResponse.getPayload()).build();
}

// Check if the client authentication is successful
if (!clientAuthnContext.isAuthenticated()) {
// create error response
PushAuthErrorResponse errorResponse = pushAuthRequestValidator
.createErrorResponse(HttpServletResponse.SC_UNAUTHORIZED,
clientAuthnContext.getErrorCode(), clientAuthnContext.getErrorMessage());
return Response.status(errorResponse.getHttpStatusCode())
.entity(errorResponse.getPayload()).build();
}

Expand Down
Loading