Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokens not revoking issue #194

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix tokens not revoking issue #194

merged 1 commit into from
Nov 13, 2024

Conversation

anjuchamantha
Copy link
Contributor

Fix tokens not revoking issue

Tokens are not revoked after arrangement revoke request. Eventhough the token type is set as refresh_token, the access_token is passed to IS revokeTokenByOAuthClient method. This PR fixes this by passing refresh_token.

Related Issues

Applicable Labels: CDS Toolkit


Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

@Akila94 Akila94 merged commit e7f25b8 into wso2:3.0.0 Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants