[Accelerator 4] Adding consent enforcement and error handling implementation #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashi1993
changed the title
Akila94
reviewed
Oct 23, 2024
...lerators/fs-apim/repository/resources/apis/Accounts/accounts-dynamic-endpoint-insequence.xml
Outdated
Show resolved
Hide resolved
Ashi1993
changed the title
Akila94
reviewed
Oct 28, 2024
...financial/services/accelerator/gateway/executor/impl/consent/ConsentEnforcementExecutor.java
Outdated
Show resolved
Hide resolved
| @@ -25,7 +25,7 @@ | |||
| <RequestRouter>org.wso2.financial.services.accelerator.gateway.executor.core.DefaultRequestRouter</RequestRouter> | |||
| {% endif %} | |||
| <FinancialServicesGatewayExecutors> | |||
| {% for type in financial_services.gateway.openbanking_gateway_executors.type %} | |||
| {% for type in financial_services.gateway.gateway_executors.type %} | |||
There was a problem hiding this comment.
{% for type in financial_services.gateway.gateway_executors.type %}
Do we need gateway twice here?
| @@ -203,6 +203,7 @@ | |||
| com.fasterxml.jackson.core;version="${jackson.databinding.version}", | |||
| org.owasp.encoder;version="${encoder.wso2.version}" | |||
| </Import-Package> | |||
| <DynamicImport-Package>*</DynamicImport-Package> | |||
There was a problem hiding this comment.
Why is this needed?
There was a problem hiding this comment.
As discussed offline had to add this to solve dependency not identifying issue.
| this.status = ResponseStatus.FOUND; | ||
| this.payload = createDefaultErrorObject(errorRedirectURI, error.toString(), errorDescription, state); | ||
| this.payload = createDefaultErrorObject(errorURI, error.toString(), errorDescription, state); | ||
| } | ||
| } | ||
|
|
||
| public JSONObject createDefaultErrorObject(URI redirectURI, String errorCode, String errorMessage, String state) { |
There was a problem hiding this comment.
Suggested change
| public JSONObject createDefaultErrorObject(URI redirectURI, String errorCode, String errorMessage, String state) { | |
| public JSONObject createDefaultErrorObject(URI redirectURI, String errorCode, String errorDescription, String state) { |
| username = OAuth2Util.resolveUsernameFromUserId(ConsentExtensionConstants.TENANT_DOMAIN, userID); | ||
| } | ||
| } catch (UserStoreException e) { | ||
| return null; |
There was a problem hiding this comment.
Shall we add a debug log here?
| // From date is earlier than To date | ||
| return toDate.isAfter(fromDate); | ||
| // From date is equal or earlier than To date | ||
| return toDate.isEqual(fromDate) || toDate.isAfter(fromDate); | ||
| } catch (DateTimeParseException e) { | ||
| return false; |
There was a problem hiding this comment.
Shall we add a debug log here too?
| return; | ||
| } | ||
|
|
||
| boolean isValid = (boolean) jsonResponse.get(IS_VALID); |
| JSONArray errorList = new JSONArray(); | ||
| for (FSExecutorError error : errors) { | ||
| JSONObject errorObj = new JSONObject(); | ||
| errorObj.put("code", error.getCode()); |
| return errorList; | ||
| } | ||
|
|
||
| private boolean isAnyClientErrors(HashSet<String> statusCodes) { |
There was a problem hiding this comment.
Suggested change
| private boolean isAnyClientErrors(HashSet<String> statusCodes) { | |
| private boolean isAnyClientErrors(Set<String> statusCodes) { |
Comment on lines
174
to
179
| for (String statusCode : statusCodes) { | ||
| if (statusCode.startsWith("4")) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; |
| "consentInformation": { | ||
| "key": "value" | ||
| } | ||
| } |
Akila94
approved these changes
Nov 6, 2024
VimukthiRajapaksha
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding consent enforcement implementation
Issue link: required
Doc Issue: Optional, link issue from documentation repository
Applicable Labels: Spec, product, version, type (specify requested labels)
Development Checklist
Testing Checklist