Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accelerator 4] Adding Consent and Authentication Webapp Implementation #110

Merged
merged 6 commits into from
Sep 10, 2024
Merged

[Accelerator 4] Adding Consent and Authentication Webapp Implementation #110

merged 6 commits into from
Sep 10, 2024

Conversation

Ashi1993
Copy link
Contributor

Adding Consent and Authentication Webapp Implementation

This PR adds Consent and Authentication Webapp Implementation

Issue link: https://github.com/wso2-enterprise/solutions-bfsi/issues/20

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

aka4rKO
aka4rKO reviewed Sep 10, 2024
View reviewed changes
...ava/org/wso2/financial/services/accelerator/common/config/FinancialServicesConfigParser.java Outdated
Iterator consentTypeElement = financialServicesGatewayExecutors.getChildElements();
while (consentTypeElement.hasNext()) {
OMElement consentType = (OMElement) consentTypeElement.next();
String consentTypeName = consentType.getLocalName();
Map<Integer, String> executors = new HashMap<>();
//obtaining each Executor element under each consent type
// obtaining each Executor element under each consent type
Iterator<OMElement> obExecutor = consentType.getChildrenWithName(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename this to something other than ob?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed in fe1e2b6

aka4rKO
aka4rKO reviewed Sep 10, 2024
View reviewed changes
...n/src/test/java/org/wso2/financial/services/accelerator/common/test/FSConfigParserTests.java Outdated
@@ -68,16 +69,16 @@ public void testConfigParserInit() {
Assert.assertEquals(openBankingConfigParser.getConfiguration().get("Sample.FSHandler"), "DummyValue");
Assert.assertEquals(openBankingConfigParser.getConfiguration().get("Sample.FSHandler2"), "property.value");
Assert.assertNotNull(openBankingConfigParser.getConfiguration().get("Sample.FSHandler4"));
Map<String, Map<Integer, String>> openBankingExecutors =
FinancialServicesConfigParser.getInstance().getFinancialServicesExecutors();
Map<String, Map<Integer, String>> openBankingExecutors = FinancialServicesConfigParser.getInstance()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed in fe1e2b6

aka4rKO
aka4rKO reviewed Sep 10, 2024
View reviewed changes
....services.accelerator.authentication.endpoint/src/main/webapp/libs/bootstrap_3.4.1/js/npm.js Outdated
require('../../js/popover.js')
require('../../js/scrollspy.js')
require('../../js/tab.js')
require('../../js/affix.js')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add an EOF line here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed in 33337e1

@hasithakn hasithakn merged commit 4f0b58b into wso2:main Sep 10, 2024
2 checks passed
@Ashi1993 Ashi1993 changed the title Adding Consent and Authentication Webapp Implementation [Accelerator 4] Adding Consent and Authentication Webapp Implementation Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aka4rKO aka4rKO aka4rKO approved these changes

@hasithakn hasithakn hasithakn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashi1993 @hasithakn @aka4rKO