Fix health check docs #8697
Open
Fix health check docs #8697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashera96
reviewed
Nov 8, 2024
Comment on lines
-243
to
-245
| [carbon_health_check.health_checker.data_source_health_checker] | ||
| enable =false | ||
| order = 98 |
There was a problem hiding this comment.
Shouldn't this be the configuration for super tenant health checker? Just like the configurations that come before this are for carbon_health_check.health_checker.data_source_health_checker and carbon_health_check.health_checker.data_source_health_checker.properties; I believe this should be a typo. We should change this from [carbon_health_check.health_checker.data_source_health_checker] to [carbon_health_check.health_checker.super_tenant_health_checker]
[carbon_health_check.health_checker.super_tenant_health_checker]
enable =false
order = 98
| @@ -32,7 +32,7 @@ This section guides you through deploying the Carbon Health Check components in | |||
|
|
|||
| 5. Copy the webapp `api#health-check#v1.0.war`, which is found in the `<HEALTH_CHECK_HOME>/components/org.wso2.carbon.healthcheck.api.endpoint/target/` directory and paste it in the `<API-M_HOME>/repository/deployment/server/webapps` directory. | |||
|
|
|||
| 6. Copy the `health-check.config.xml` configuration file found in the `<API_HOME>/features/org.wso2.carbon.healthcheck.server_1.0.0` directory to your `<PRODUCT_HOME>/repository/conf/` directory. | |||
| 6. Copy the `health-check-config.xml` configuration file found in the `<HEALTH_CHECK_HOME>/features/org.wso2.carbon.healthcheck.server.feature/resources` directory to your `<PRODUCT_HOME>/repository/conf/` directory. | |||
There was a problem hiding this comment.
Will changing the health-check-config.xml work fine for this? Isn't it the j2 or a toml file that we should be editing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #8491