Update SmartDashboard to use WPILib-2023.4.3 NetworkTable APIs #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SchedulerType. But it doesn't work anyway so left a comment about it.
… no longer gets Java errors, but it still doesn't work right; attempt to get remove for RobotPreferences to work -- no success.
|
You can apply this diff to fix the build, automatically include wpinet and fix the live window test project too. |
…ferences table and also with the cancel buttons of the scheduler widget
…dControllerType from Motor to Speed Controller
…han string values
… cause uncaught errors
…ot each suffer an out-of-bounds array reference
…NT before processing the save file; fixes the problem of string chooser not appearing on dashboard when it is listed in the save file
is misnamed -- it now just ensures that DSClient is not enabled until the save file has been loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm posting this as a preliminary effort, not yet ready for merging.
After having some issues with SmartDashboard this season I thought I would attempt to contribute an update to use current NetworkTables APIs rather than being forever stuck on the ITable inteface that was already deprecated in 2021.
This is the state of things so far. There are a few changes pending that have been made in PRs for the WPILib 2021 version and not yet ported here. I'll keep this in Draft status 'til those are done.
This is my first foray into programming directly with the NT API so please excuse and correct any awkwardnesses that I may have committed. One question that I have about the API is that it has interfaces named both
TableListenerandSubTableListenerthat appear essentially identical. I think I eventually decided I neededSubTableListener, but I'm wondering about the use ofTableListener.Thinking about this longer-term: what do the WPILib team and FRC teams in general want to see happen with SmartDashboard? Speaking for my team, we like SmartDashboard's relative lightweight (compared to Shuffleboard) for a competition dashboard that only needs to provide controls for configuring the robot. We have no interest in using it for development, robot tuning, etc. -- glass works fine for that. Similarly, on-robot logging supplants the need to do any logging from the dashboard for us. Given that, I see little value in adding LiveWindow widgets for many of the sendables that have been added to WPILib in recent years. And given SmartDashboard's primitive automatic layout ability produces really unusable results for the large number of Sendables in current-day robot code I have to wonder whether removing the LiveWindow displays altogether would be preferable to the current jumble of supported and unsupported LiveWindow types.