Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support symlinked packages #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlCalzone
Copy link

When using package managers like pnpm or yarn v3 with the pnpm linker, the current check for methods that come from this library doesn't work. The reason is that path.resolve(signature.declaration.getSourceFile().fileName is a path like node_modules/typescript-is/index.d.ts, but path.resolve(path.join(__dirname, '..', '..', 'index.d.ts')) looks like this node_modules/.store/typescript-is-virtual-6354fcdb88/node_modules/typescript-is/index.d.ts. The former folder is a symlink to the latter.

Using fs.realpathSync we can resolve the symlinked path to the real one and make sure the transformer works in these contexts.

I threw in some caching for the lookup via PartialVisitorContext.canonicalPaths, if this isn't desired, it also works using fs directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant