Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using package managers like
pnpm
oryarn v3
with thepnpm
linker, the current check for methods that come from this library doesn't work. The reason is thatpath.resolve(signature.declaration.getSourceFile().fileName
is a path likenode_modules/typescript-is/index.d.ts
, butpath.resolve(path.join(__dirname, '..', '..', 'index.d.ts'))
looks like thisnode_modules/.store/typescript-is-virtual-6354fcdb88/node_modules/typescript-is/index.d.ts
. The former folder is a symlink to the latter.Using
fs.realpathSync
we can resolve the symlinked path to the real one and make sure the transformer works in these contexts.I threw in some caching for the lookup via
PartialVisitorContext.canonicalPaths
, if this isn't desired, it also works usingfs
directly.