You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only suggestion for me would be to add an associated view model test suite so that to help any readers understand any or all the use cases involved without needing to have it trigger this whole flow via manual UI testing.
Green CI should be sufficient to test this.
@oguzkocer I hope you don't mind me asking you for a review. I feel like I've worn David out with review requests :) No rush on this as I'm about to take a few days AFK.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic tests to the email verification banner view model which we recently added to the Me screen, as suggested on the original PR:
Green CI should be sufficient to test this.
@oguzkocer I hope you don't mind me asking you for a review. I feel like I've worn David out with review requests :) No rush on this as I'm about to take a few days AFK.