Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email verification banner tests #21783

Merged
merged 10 commits into from
Apr 9, 2025
Merged

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Apr 1, 2025

This PR adds basic tests to the email verification banner view model which we recently added to the Me screen, as suggested on the original PR:

The only suggestion for me would be to add an associated view model test suite so that to help any readers understand any or all the use cases involved without needing to have it trigger this whole flow via manual UI testing.

Green CI should be sufficient to test this.

@oguzkocer I hope you don't mind me asking you for a review. I feel like I've worn David out with review requests :) No rush on this as I'm about to take a few days AFK.

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 1, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 1, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21783-72bd1b5
Commit72bd1b5
Direct Downloadjetpack-prototype-build-pr21783-72bd1b5.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 1, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21783-72bd1b5
Commit72bd1b5
Direct Downloadwordpress-prototype-build-pr21783-72bd1b5.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 39.29%. Comparing base (34292ad) to head (72bd1b5).
Report is 2 commits behind head on trunk.

Files with missing lines Patch % Lines
...ilverificationbanner/EmailVerificationViewModel.kt 0.00% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21783   +/-   ##
=======================================
  Coverage   39.29%   39.29%           
=======================================
  Files        2125     2125           
  Lines       99862    99862           
  Branches    15386    15386           
=======================================
  Hits        39240    39240           
  Misses      57144    57144           
  Partials     3478     3478           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Apr 2, 2025

@nbradbury nbradbury requested a review from oguzkocer April 2, 2025 11:23
@nbradbury nbradbury marked this pull request as ready for review April 2, 2025 11:23
@nbradbury nbradbury merged commit fecfc60 into trunk Apr 9, 2025
26 checks passed
@nbradbury nbradbury deleted the issue/email-verification-banner-tests branch April 9, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants