Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in client examples that use PKCS11. #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anhu
Copy link
Member

@anhu anhu commented Sep 12, 2024

No description provided.

@anhu anhu self-assigned this Sep 12, 2024
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings on build:

client-tls-pkcs11-ecc.c: In function ‘client_tls’:
client-tls-pkcs11-ecc.c:49:24: warning: unused variable ‘shutdown’ [-Wunused-variable]
   49 |     int                shutdown = 0;
      |                        ^~~~~~~~
client-tls-pkcs11-ecc.c:46:24: warning: unused variable ‘size’ [-Wunused-variable]
   46 |     socklen_t          size = sizeof(servAddr);
      |                        ^~~~
gcc -o client-tls-pkcs11-rsa client-tls-pkcs11-rsa.c -Wall -I/usr/local/include -Os -L/usr/local/lib -lm -lwolfssl
client-tls-pkcs11-rsa.c: In function ‘client_tls’:
client-tls-pkcs11-rsa.c:49:24: warning: unused variable ‘shutdown’ [-Wunused-variable]
   49 |     int                shutdown = 0;
      |                        ^~~~~~~~
client-tls-pkcs11-rsa.c:46:24: warning: unused variable ‘size’ [-Wunused-variable]
   46 |     socklen_t          size = sizeof(servAddr);
      |                        ^~~~

When updating the pkcs11 examples please touch up all the cases of :

 1125 |     unsigned char exp_sha512[SHA512_DIGEST_SIZE] = {
      |                              ^~~~~~~~~~~~~~~~~~
      |                              WC_SHA512_DIGEST_SIZE

@@ -0,0 +1,245 @@
/* client-tls-pkcs11.c
*
* Copyright (C) 2006-2020 wolfSSL Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the copyright year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants