Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Invalid value prop-type #151

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Invalid value prop-type #151

wants to merge 3 commits into from

Conversation

bilobom
Copy link

@bilobom bilobom commented Apr 26, 2021

  • When changing any input using keyboard's up and down arrows, the following warning occurs :
Warning: Failed prop type: Invalid prop `value` of type `number` supplied to `Input`, expected `string`.
    in Input (created by YearInput/ MonthInput/ DayInput/ HourInput ...etc )
  • This PR seeks to solve this by casting values passed to different inputs to String, excluding null or undefined

fixes issue #146

wojtekmaj and others added 3 commits March 24, 2021 13:16
@wojtekmaj
Update @wojtekmaj/enzyme-adapter-react-17 to 0.6.0
0fe085f
@wojtekmaj
Update y18n from 4.0.0 to 4.0.1
55c91f4
@bilobom
fix: Invalid value prop-type
9964189 
For Date & Time inputs when value is changed using keyboard  up and down arrows

fixes issue wojtekmaj#146
@bilobom bilobom mentioned this pull request Apr 27, 2021
Closed
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 60dab23 to 0e0d0fa Compare January 29, 2022 06:58
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 26e7d57 to a9e7372 Compare March 24, 2022 08:38
@wojtekmaj wojtekmaj force-pushed the main branch 3 times, most recently from 692ce53 to 404049f Compare September 6, 2022 09:42
@wojtekmaj wojtekmaj force-pushed the main branch 7 times, most recently from 2f0138d to dc0eb5c Compare October 24, 2022 15:33
@wojtekmaj wojtekmaj force-pushed the main branch 6 times, most recently from 39ad647 to 2e5085f Compare November 8, 2022 11:09
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from e6f5a4a to aaea0be Compare January 4, 2023 23:23
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 26bc1d8 to 33f443b Compare March 2, 2023 08:47
@wojtekmaj wojtekmaj force-pushed the main branch 3 times, most recently from d403f12 to 7887418 Compare April 1, 2023 11:48
@wojtekmaj wojtekmaj force-pushed the main branch 4 times, most recently from 557c2c7 to 4aa7ede Compare April 5, 2023 11:01
@wojtekmaj wojtekmaj force-pushed the main branch 3 times, most recently from d7656e3 to 31074d0 Compare October 23, 2023 10:22
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 3a6b9ed to 1cd461b Compare November 2, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilobom @wojtekmaj