Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for updating a range without losing the opposite end of the selection #928

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GCastilho
Copy link

Implemented the 'keepBoundarySelected' prop, allowing users to "update" a range by clicking on one of its ends.

This new property configures whether the range should remain selected if the user clicks on one of the "range boundaries". For instance, if the user selects days 1 and 3, and subsequently clicks on day 3 again, day 1 will remain selected to "update" the range.

Also implemented some fixes on the CSS that became particularly noticeable after this feature.

If there are any problems with this PR or if it will not be accepted for any reason, please let me know so I can take the necessary actions.

G@briel Castilho added 3 commits August 9, 2024 10:51
-- Implemented prop 'keepBoundarySelected', enabling users to "update" a range by clicking on one of its ends
-- fix active calendar__tile with the wrong color when also hovering. This is particularly noticeable when updating a range with 'keepBoundarySelected'
-- fix focused calendar__tile with the same color as a hovered tile, causing it to remain "selected" when updating a range (and in other specific cases)
@GCastilho GCastilho force-pushed the feat/keep-range-when-updating-selection branch from 111e202 to 0f5abd4 Compare August 9, 2024 13:52
@GCastilho
Copy link
Author

@wojtekmaj I've rebased the branch with the current state of main, can you review this PR or confirm that this feature will not be accepted?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant