Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add client side filtering recipe #6

Merged
merged 2 commits into from
Nov 13, 2024
Merged

add client side filtering recipe #6

merged 2 commits into from
Nov 13, 2024

Conversation

tomkralidis
Copy link
Collaborator

cc @antje-s @6a6d74 @golfvert, as discussed at ET-W2IT 2024-11-11.

@tomkralidis tomkralidis added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 12, 2024
antje-s
antje-s approved these changes Nov 12, 2024
View reviewed changes
Copy link

@antje-s antje-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, looks good only one double "additional" in line 155 to be deleted

amilan17
amilan17 reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple suggestions inline

@tomkralidis
Copy link
Collaborator Author

Thanks for the feedback @antje-s @amilan17. PR updated.

@golfvert golfvert merged commit fd729a3 into main Nov 13, 2024
1 check passed
@tomkralidis tomkralidis deleted the mqp-client-side-filters branch November 13, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilan17 amilan17 amilan17 left review comments

@antje-s antje-s antje-s approved these changes

@golfvert golfvert Awaiting requested review from golfvert

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomkralidis @amilan17 @antje-s @golfvert