fix: updated calcualtions for showSixWeeks #2562
Open
+19
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksymA26
commented
Nov 29, 2024
| let before: XDate[] = []; | ||
| let after: XDate[] = []; | ||
| const days = dates.map(day => day.clone()); |
There was a problem hiding this comment.
Added this to insure immutability, I'm not sure if this is indeed needed tho
MaksymA26
commented
Nov 29, 2024
|
|
||
| if (showSixWeeks && !daysForSixWeeks) { | ||
| if (42 - daysOnPage > 7) { |
There was a problem hiding this comment.
for months with 28 days (5 weeks) (Feb 2026) => add 7 days before
Otherwise there's situation where 2 weeks from next month are displayed at the end and it just doesnt look right
If it bothers you we can just do to.addDays(42 - daysOnPage) but it's uglier in my opinion
MaksymA26
commented
Nov 29, 2024
|
|
||
| if (showSixWeeks && !daysForSixWeeks) { | ||
| if (42 - daysOnPage > 7) { |
There was a problem hiding this comment.
42 = 6weeks * 7days
Should I move it to variable or you can understand from the context what it is ?
|
@Inbal-Tish Hi, could you please take a look at this PR (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: