Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): fix race condition when configuring git #71

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

tugrulates
Copy link
Member

No description provided.

@Copilot Copilot bot review requested due to automatic review settings February 28, 2025 01:26
@github-actions github-actions bot added the core label Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR fixes a race condition when configuring git by replacing concurrent execution with sequential execution for applying configuration entries.

  • Removed the usage of an asynchronous pool from the git configuration process.
  • Replaced the pool call with a sequential for‑of loop to ensure commands execute in order.

Reviewed Changes

File Description
core/git/git.ts Updates the configuration setting flow from concurrent to sequential execution to avoid race conditions

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@tugrulates tugrulates merged commit cb66b02 into main Feb 28, 2025
8 checks passed
@tugrulates tugrulates deleted the fix/fit/race branch February 28, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant