Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(forge): add most of missing tests #70

Merged
merged 4 commits into from
Feb 28, 2025
Merged

test(forge): add most of missing tests #70

merged 4 commits into from
Feb 28, 2025

Conversation

tugrulates
Copy link
Member

No description provided.

@Copilot Copilot bot review requested due to automatic review settings February 28, 2025 00:56
@github-actions github-actions bot added the forge label Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds extensive missing tests for various functionalities in the forge module and refines some core functions to improve error handling and configuration clarity.

  • Adds tests for changelog generation, release creation (initial, bump, and draft), binary compilation, and package version bumping.
  • Refactors parts of app.ts, compile.ts, release.ts, and bump.ts to use clearer configuration checks and explicit parameters.

Reviewed Changes

File Description
tool/forge/changelog.test.ts Introduces tests for validating changelog output.
tool/forge/release.test.ts Adds comprehensive tests for various release flows.
tool/forge/compile.test.ts Implements tests for compile function, binary creation, and artifact bundling.
tool/forge/bump.test.ts Enhances tests for package version bumping and pull request creation.
tool/forge/app.ts Refactors directory determination logic; introduces a magic string "T".
tool/forge/compile.ts Adds explicit dist configuration; refines compile configuration error handling.
tool/forge/release.ts Updates release creation logic including enhanced error messaging and repository handling.
tool/forge/bump.ts Refines bump logic and adjusts configuration usage for repository and user settings.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tool/forge/app.ts:83

  • [nitpick] The use of the magic string "T" is unclear. Consider replacing it with a named constant to clearly convey its purpose and improve maintainability.
while (basename(dirname(directory)) !== "T") {
@tugrulates tugrulates changed the title testing(forge): add most of missing tests test(forge): add most of missing tests Feb 28, 2025
@tugrulates tugrulates merged commit 89d1eb8 into main Feb 28, 2025
10 checks passed
@tugrulates tugrulates deleted the testing/forge branch February 28, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant