Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report all hostname state failures for URLPattern #863

Merged
merged 2 commits into from
Mar 19, 2025
+5 −4
Merged

Report all hostname state failures for URLPattern #863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffaef5a
Report all hostname state failures for URLPattern
annevk Mar 13, 2025
7c15b77
Update url.bs
annevk Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions url.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2538,15 +2538,16 @@ and then runs these steps:
<a>file host state</a>.

<li>
<p>Otherwise, if <a>c</a> is U+003A (:) and <var>insideBrackets</var> is false, then:
<p>Otherwise, if <a>c</a> is U+003A (:) and <var>insideBrackets</var> is false:

<ol>
<li><p>If <var>buffer</var> is the empty string, <a>host-missing</a> <a>validation error</a>,
return failure.
<!-- No URLs with port, but without host. -->

<li><p>If <var>state override</var> is given and <var>state override</var> is
<a>hostname state</a>, then return.
<a>hostname state</a>, then return failure.
<!-- API validation error -->

<li><p>Let <var>host</var> be the result of <a>host parsing</a> <var>buffer</var> with
<var>url</var> <a>is not special</a>.
Expand All @@ -2566,7 +2567,7 @@ and then runs these steps:
<li><p><var>url</var> <a>is special</a> and <a>c</a> is U+005C (\)
</ul>

<p>then decrease <var>pointer</var> by 1, and then:
<p>then decrease <var>pointer</var> by 1, and:

<ol>
<li><p>If <var>url</var> <a>is special</a> and <var>buffer</var> is the empty string,
Expand All @@ -2576,7 +2577,7 @@ and then runs these steps:

<li><p>Otherwise, if <var>state override</var> is given, <var>buffer</var> is the empty
string, and either <var>url</var> <a>includes credentials</a> or <var>url</var>'s
<a for=url>port</a> is non-null, return.
<a for=url>port</a> is non-null, then return failure.
<!-- API validation error -->

<li><p>Let <var>host</var> be the result of <a>host parsing</a> <var>buffer</var> with
Expand Down