Provide "suggestedFilename" in "WebDriver BiDi download started" hook #11139
+76
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2025
sadym-chromium
changed the title
|
@domenic could you please take a look? |
|
Can you ensure the build is passing first? |
Oh, sure! Sorry for that. Fixed. |
domenic
reviewed
Mar 27, 2025
| @@ -25778,7 +25786,7 @@ document.body.appendChild(wbr);</code></pre> | |||
| <li><p>Let <var>filename</var> be the undefined value.</p></li> | |||
|
|
|||
| <!-- Content-Disposition: attachment; filename="" is always honoured, even cross-origin --> | |||
| <li><p>If the resource has a `<code data-x="http-content-disposition">Content-Disposition</code>` | |||
| <li><p>If the <var>resource</var> has a `<code data-x="http-content-disposition">Content-Disposition</code>` | |||
There was a problem hiding this comment.
Nice job adding the explicit resource variable. However, here and below, it's better to use just "resource" instead of "the resource". (Or I guess response, once we make the update I suggest above.)
Thanks for the feedback. I believe it is addressed. Please consider merging if there are no other concerns |
domenic
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide "suggestedFilename" in "WebDriver BiDi download started" hook. Addressing w3c/webdriver-bidi#840.
browsingContext.downloadWillBeginWPT tests.browsingContext.downloadWillBeginevent GoogleChromeLabs/chromium-bidi#3248(See WHATWG Working Mode: Changes for more details.)
/browsers.html ( diff )
/browsing-the-web.html ( diff )
/infrastructure.html ( diff )
/links.html ( diff )