Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filter-control] Always return the same control container target #7445

Closed
wants to merge 1 commit into from
Closed

[filter-control] Always return the same control container target #7445

wants to merge 1 commit into from

Conversation

jayaddison
Copy link

@jayaddison jayaddison commented Aug 1, 2024 •
edited
Loading

🤔Type of Request

  • Bug fix
  • New feature
  • Improvement
  • Documentation
  • Other

🔗Resolves an issue?

Fix #7171.

📝Changelog
In the filter-control getControlContainer function, always return the same target control container, regardless of whether the height (fixed-header) option is enabled, and regardless of the filter control _initialized state when it is.

  • Core
  • Extensions

💡Example(s)?

☑️Self Check before Merge

⚠️ Please check all items below before reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Edit: untick the reviewer checkboxes that I'd filled by mistake.

@jayaddison
[filter-control] Always return the same control container target
dda21c3 
In particular, when fixed-header mode is enabled, don't return
different control containers depending on the status of the
filter-control component.
@jayaddison jayaddison mentioned this pull request Aug 1, 2024
Open
@jayaddison
Copy link
Author

@wenzhixin I haven't yet heard from any affected bugreporters, but I believe that this pull request solves the problem described in #7171 when the filter-control extension is used in combination with the mobile extension. I'd be glad for any code review and suggestions.

@jayaddison
Copy link
Author

Due to my unfamiliarity with this part of the bootstrap-table codebase, combined with an apparent absence of demand (and therefore assistance testing the fix), and also the fact that this feature isn't currently required by the project I'm working on (it would be nice, because it might allow removal of other dependencies) -- on balance I'm going to close this to reduce my personal tasklist.

To anyone who might find this could useful: please feel free to retrieve the commits from this branch and continue work from here. Using git fetch <remote> pull/7445/head:localbranch should allow retrieving up to commit dda21c3 into a local branch.

@jayaddison jayaddison closed this Oct 20, 2024
@jayaddison jayaddison deleted the fix/7171 branch October 20, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setting height option breaks the Filter Control extension
1 participant
@jayaddison