Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ignore CHROME_BIN/FIREFOX_BIN environment variables #1157

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

fippo
Copy link
Member

@fippo fippo commented Apr 20, 2024

CHROME_BIN already exists on github actions, avoiding the download of the beta/canary version.
Also use path.join to join path to browser

@fippo fippo force-pushed the test-logging branch 6 times, most recently from 5bc6a87 to 6cc02fd Compare April 20, 2024 23:24
CHROME_BIN already exists on github actions, avoiding the download of the beta/canary version.
Also use path.join to join path to browser
@fippo fippo changed the title test: use path.join to join path to browser test: ignore CHROME_BIN/FIREFOX_BIN environment variables Apr 20, 2024
@fippo fippo marked this pull request as ready for review April 20, 2024 23:29
@fippo fippo merged commit b5e5f71 into main Apr 20, 2024
7 checks passed
@fippo fippo deleted the test-logging branch April 20, 2024 23:29
fippo added a commit to fippo/webrtc that referenced this pull request Apr 20, 2024
following what was done in adapter which is now back to supporting
Firefox stable. Also ignore CHROME_BIN environment variable to download
the actual Chrome version, see
  webrtcHacks/adapter#1157
fippo added a commit to fippo/webrtc that referenced this pull request Apr 20, 2024
following what was done in adapter which is now back to supporting
Firefox stable. Also ignore CHROME_BIN environment variable to download
the actual Chrome version, see
  webrtcHacks/adapter#1157
fippo added a commit to fippo/webrtc that referenced this pull request Apr 20, 2024
following what was done in adapter which is now back to supporting
Firefox stable. Also ignore CHROME_BIN environment variable to download
the actual Chrome version, see
  webrtcHacks/adapter#1157
fippo added a commit to fippo/webrtc that referenced this pull request Apr 20, 2024
following what was done in adapter which is now back to supporting
Firefox stable. Also ignore CHROME_BIN environment variable to download
the actual Chrome version, see
  webrtcHacks/adapter#1157
fippo added a commit to fippo/webrtc that referenced this pull request Apr 20, 2024
following what was done in adapter which is now back to supporting
Firefox stable. Also ignore CHROME_BIN environment variable to download
the actual Chrome version, see
  webrtcHacks/adapter#1157
fippo added a commit to fippo/webrtc that referenced this pull request Apr 20, 2024
following what was done in adapter which is now back to supporting
Firefox stable. Also ignore CHROME_BIN environment variable to download
the actual Chrome version, see
  webrtcHacks/adapter#1157
fippo added a commit to fippo/webrtc that referenced this pull request Apr 21, 2024
following what was done in adapter which is now back to supporting
Firefox stable. Also ignore CHROME_BIN environment variable to download
the actual Chrome version, see
  webrtcHacks/adapter#1157
fippo added a commit to fippo/webrtc that referenced this pull request Apr 21, 2024
following what was done in adapter which is now back to supporting
Firefox stable. Also ignore CHROME_BIN environment variable to download
the actual Chrome version, see
  webrtcHacks/adapter#1157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant