Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: next major release #4066

Closed
wants to merge 2 commits into from
Closed

feat: next major release #4066

wants to merge 2 commits into from

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Prepare for the next major version.

Does this PR introduce a breaking change?
Yes

Other information
Keep it open until all breaking changes are done.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.72%. Comparing base (f7977af) to head (6ee2f45).
Report is 155 commits behind head on master.

Files with missing lines Patch % Lines
packages/webpack-cli/src/webpack-cli.ts 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4066      +/-   ##
==========================================
+ Coverage   90.59%   90.72%   +0.12%     
==========================================
  Files          22       22              
  Lines        1702     1703       +1     
  Branches      491      491              
==========================================
+ Hits         1542     1545       +3     
+ Misses        160      158       -2     
Files with missing lines Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 92.64% <90.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7977af...6ee2f45. Read the comment docs.

@@ -3,8 +3,8 @@
"dockerFile": "Dockerfile",
"runArgs": ["-u", "node"],
"settings": {
"terminal.integrated.shell.linux": "/bin/bash"
"terminal.integrated.shell.linux": "/bin/bash",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comma

},
"postCreateCommand": "yarn install && yarn build",
"extensions": ["dbaeumer.vscode-eslint", "esbenp.prettier-vscode"]
"extensions": ["dbaeumer.vscode-eslint", "esbenp.prettier-vscode"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-,,-

@snitin315 snitin315 closed this Oct 15, 2024
@snitin315 snitin315 deleted the next branch October 15, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants