feat: parseIdentifier fast path for requests without \0 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
commented
Jan 13, 2025
|
|
||
| /** | ||
| * @param {string} identifier identifier | ||
| * @returns {[string, string, string]|null} parsed identifier | ||
| */ | ||
| function parseIdentifier(identifier) { | ||
| if (!identifier) { | ||
| return null; |
There was a problem hiding this comment.
Possibly this should be ["","",""]?
There was a problem hiding this comment.
It appears that in practice it doesn't matter to callers.
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
alexander-akait
approved these changes
Feb 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 92.50% 92.41% -0.10%
==========================================
Files 44 44
Lines 2135 2149 +14
Branches 657 662 +5
==========================================
+ Hits 1975 1986 +11
- Misses 131 132 +1
- Partials 29 31 +2 ☔ View full report in Codecov by Sentry. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fast path to
parseIdentifierthat avoids the overhead of regex processing when the input does not contain a null character. Improves performance ofparseIdentifierby ~75% for typical usage on NodeJS 18.19.1.Before:
After:
Adds additional unit tests to
parseIdentifierfor NULL-escaped strings.