perf(memory): avoid creating a new array inside doResolve

webpack · Jul 17, 2024 · 7b6834c · 7b6834c
2 parents fd3bde2 + a10531a
commit 7b6834c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/Resolver.js b/lib/Resolver.js
@@ -692,7 +692,11 @@ class Resolver {
 			}
 			newStack.add(stackEntry);
 		} else {
-			newStack = new Set([stackEntry]);
+			// creating a set with new Set([item])
+			// allocates a new array that has to be garbage collected
+			// this is an EXTREMELY hot path, so let's avoid it
+			newStack = new Set();
+			newStack.add(stackEntry);
 		}
 		this.hooks.resolveStep.call(hook, request);