This repository was archived by the owner on Aug 30, 2020. It is now read-only.
dev: create basic web server #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baocancode
commented
Mar 1, 2019
| loaders: { | ||
| scss: { | ||
| implementation: sass, | ||
| }, |
There was a problem hiding this comment.
sass is the new implementation to replace node-sass
baocancode
commented
Mar 1, 2019
packages/web/tsconfig.json
Outdated
| "outDir": "lib", | ||
| "target": "es5", | ||
| "module": "es2015", | ||
| "moduleResolution": "node" |
There was a problem hiding this comment.
Recommended config from https://vuejs.org/v2/guide/typescript.html
baocancode
commented
Mar 1, 2019
| "experimentalDecorators": true, | ||
| "allowJs": true | ||
| } | ||
| } |
There was a problem hiding this comment.
Dummy file to avoid Vetur error during development, suggested by vuejs/vetur#815 (comment)
baocancode
commented
Mar 1, 2019
|
|
||
| render (h: CreateElement) { | ||
| return ( | ||
| <h1 class='blue'>Welcome to {this.appName}!</h1> |
There was a problem hiding this comment.
Use class instead of className because JSX for Vue is different from React: https://github.com/vuejs/babel-plugin-transform-vue-jsx#difference-from-react-jsx
nmchau
approved these changes
Mar 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4.