Skip to content

Commit

Permalink
Fix static checks in Symfony 5
Browse files Browse the repository at this point in the history
  • Loading branch information
@lruozzi9
lruozzi9 committed Dec 16, 2024
1 parent 7019b93 commit 5a35c4a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion phpstan.neon
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
parameters:
level: max
reportUnmatchedIgnoredErrors: false
checkMissingIterableValueType: false
paths:
- src

Expand All @@ -16,4 +15,6 @@ parameters:
- 'tests/Application/src/**.php'

ignoreErrors:
-
identifier: missingType.iterableValue
- '/Parameter #1 \$configuration of method Symfony\\Component\\DependencyInjection\\Extension\\Extension::processConfiguration\(\) expects Symfony\\Component\\Config\\Definition\\ConfigurationInterface, Symfony\\Component\\Config\\Definition\\ConfigurationInterface\|null given\./'
2 changes: 2 additions & 0 deletions src/Command/ServiceChangesCommand.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,8 @@ private function applyInnerStrategy(
): bool {
/**
* @psalm-suppress InternalProperty
*
* @var string|null $innerServiceId

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.3, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.2, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)

Check failure on line 419 in src/Command/ServiceChangesCommand.php

View workflow job for this annotation

GitHub Actions / Sylius , PHP 8.1, Symfony 6.4.*, MySQL 8.0

UnnecessaryVarAnnotation 

src/Command/ServiceChangesCommand.php:419:17: UnnecessaryVarAnnotation: The @var null|string annotation for $innerServiceId is unnecessary (see https://psalm.dev/212)
*/
$innerServiceId = $definition->innerServiceId;
if ($innerServiceId !== null && str_contains($innerServiceId, '.inner')) {
Expand Down

0 comments on commit 5a35c4a

Please sign in to comment.