Add support for Python 3.13 #49970
Open
Add support for Python 3.13 #49970
+2,086
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
Azure Pipelines
ci
infra
manifest
serve
tox.ini
wave
wpt
wptrunner
gsnedders
reviewed
Jan 8, 2025
I mildly regret doing this given that some changes were needed to make the tests themselves compatible with multiple Python versions, but done :) The Azure test failures are:
So I think this could land if no further changes are requested. |
gsnedders
reviewed
Jan 9, 2025
gsnedders
requested changes
Jan 10, 2025
There was a problem hiding this comment.
https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=131812&view=logs&j=83e18e9b-478b-5a9d-ba56-9f00eadc4c2c&t=66b9c650-1fb4-5319-b61a-668ad58b4535 is still running tox -c tools/ -e py311 -- --junitxml=results.xml
Ms2ger
approved these changes
Feb 11, 2025
wpt-pr-bot
requested review from
AutomatedTester,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
This code has been dropped from Python 3.13, but we depend on FieldStorage as part of the request API. The easiest option here is to directly import the code that we are already using (the last version on the 3.12 branch, but with the deprecation warning removed), along with a copy of the PSF License which covers the cgi module code.
…ck API This is required since the logging module started using the lock as a context manager, and calling the acquire and release methods.
Remove code only needed for Python < 3.4 and ensure that we always use the spawn form of multiprocessing to avoid problems with fork and locks.
Just adding this to the excludes doesn't work, because we still check the imported code.
Lightly modified from the version in Python 3.12 as follows: * Inlined check__all__ function * Converted the use of ignore_warnings helper to use warning module directly
This is no longer support in Python 3.13, and no longer required for Python>=3.8
This avoids the use of imghdr which was removed in Ptyhon 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably this involves vendoring a copy of the removed cgi module from stdlib.