Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for fullscreen for the A/B/A case #39828

Merged
merged 1 commit into from
May 9, 2023
Merged

Add a test for fullscreen for the A/B/A case #39828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions fullscreen/api/fullscreen-reordering.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
<!DOCTYPE html>
<title>Re-requesting fullscreen doesn't fail but doesn't change order</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="../../html/semantics/popovers/resources/popover-utils.js"></script>

<div class="elements">
<div id="A">Element A</div>
<div id="B">Element B</div>
</div>

<style>
.elements>div {
width:200px;
height:200px;
}
#A { background: blue; }
#B { background: green; }
</style>

<script>
promise_test(async (t) => {
t.add_cleanup(async () => {
while (document.fullscreenElement)
await document.exitFullscreen();
});
document.onfullscreenerror = () => assert_unreached('fullscreenerror should not happen');
const A = document.getElementById('A');
const B = document.getElementById('B');
assert_true(!isTopLayer(A) && !isTopLayer(B));
await blessTopLayer(document.body);
await A.requestFullscreen();
assert_equals(document.fullscreenElement,A,'first A request');
assert_true(isTopLayer(A),'A top layer');
await blessTopLayer(A);
try {
await B.requestFullscreen();
} catch (error) {
assert_unreached('The second call to requestFullscreen rejected - it should be possible to put siblings into fullscreen together');
}
assert_equals(document.fullscreenElement,B,'B request');
assert_true(isTopLayer(B),'B top layer');
assert_true(isTopLayer(A),'A still top layer');
await blessTopLayer(B);
await A.requestFullscreen();
assert_true(isTopLayer(A),'A is still top layer');
assert_true(isTopLayer(B),'B is still top layer');
assert_equals(document.fullscreenElement,A,'A is moved back to the top of the top layer stack');
assert_equals(document.elementFromPoint(10,10),A,'A should be topmost');

await document.exitFullscreen();
assert_equals(document.fullscreenElement,B,'B goes back to being the fullscreen element');
assert_true(isTopLayer(B),'B is still top layer');
assert_false(isTopLayer(A),'A is no longer top layer');
await document.exitFullscreen();
assert_equals(document.fullscreenElement,null,'Both closed');
assert_false(isTopLayer(A),'A is no longer top layer');
assert_false(isTopLayer(B),'B is no longer top layer');
}, 'Requesting fullscreen on A, then B, then A');
</script>
16 changes: 16 additions & 0 deletions html/semantics/popovers/resources/popover-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,22 @@ async function sendEnter() {
function isElementVisible(el) {
return !!(el.offsetWidth || el.offsetHeight || el.getClientRects().length);
}
function isTopLayer(el) {
// A bit of a hack. Just test a few properties of the ::backdrop pseudo
// element that change when in the top layer.
const properties = ['right','background'];
const testEl = document.createElement('div');
document.body.appendChild(testEl);
const computedStyle = getComputedStyle(testEl, '::backdrop');
const nonTopLayerValues = properties.map(p => computedStyle[p]);
testEl.remove();
for(let i=0;i<properties.length;++i) {
if (getComputedStyle(el,'::backdrop')[properties[i]] !== nonTopLayerValues[i]) {
return true;
}
}
return false;
}
async function finishAnimations(popover) {
popover.getAnimations({subtree: true}).forEach(animation => animation.finish());
await waitForRender();
Expand Down