Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another set of floating point optimisation attemps #828

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

axic
Copy link
Member

@axic axic commented May 31, 2022

No description provided.

template <typename T>
T isnan(T value) noexcept = delete;

inline bit_cast_constexpr bool isnan(float value) noexcept
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The creation of this was motivated by making it constexpr. This could be the default in C++23: https://open-std.org/JTC1/SC22/WG21/docs/papers/2019/p0533r5.pdf

@axic axic added the optimization Performance optimization label May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #828 (3581284) into master (3581284) will not change coverage.
The diff coverage is n/a.

❗ Current head 3581284 differs from pull request most recent head a5edb7c. Consider uploading reports for the commit a5edb7c to get more accurate results

@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          88       88           
  Lines       13296    13296           
=======================================
  Hits        13200    13200           
  Misses         96       96           
Flag Coverage Δ
rust 98.48% <0.00%> (ø)
spectests 89.92% <0.00%> (ø)
unittests 99.22% <0.00%> (ø)
unittests-32 99.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Performance optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant