rust: add support for imported functions #782
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Apr 7, 2021
| @@ -617,6 +619,11 @@ FizzyInstance* fizzy_instantiate(const FizzyModule* module, | |||
| set_success(error); | |||
| return wrap(instance.release()); | |||
| } | |||
| catch (fizzy::instantiate_error const& e) | |||
| { | |||
| std::cout << e.what() << std::endl; | |||
There was a problem hiding this comment.
These was my error reporting prior to us adding proper support 😅
axic
commented
Apr 7, 2021
| } | ||
| } | ||
|
|
||
| fn create_function_import_list( |
There was a problem hiding this comment.
Still need to figure out what is the best API defining host functions, but at least this semi-finished translation layer works.
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 99.27% 98.57% -0.71%
==========================================
Files 88 2 -86
Lines 13296 1053 -12243
==========================================
- Hits 13200 1038 -12162
+ Misses 96 15 -81
Flags with carried forward coverage won't be shown. Click here to find out more. |
axic
force-pushed
the
rust-host-funcs
branch
2 times, most recently
from
aff29d7
to
f38b6ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.