Split output and logs #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create custom log handlers, which use stderr, based on the slog ConsoleHandler Issue #505 Signed-off-by: Matthew John <[email protected]>
MatthewJohn
requested review from
warrensbox,
yermulnik,
jukie,
MatrixCrawler and
crablab
as code owners
github-actions
bot
added
the
enhancement
…ght to stdout rather than using logging methods This avoids stylising output, as is done with logging. Avoids sending output to same destination as logs, which is now stderr Issue #505 Signed-off-by: Matthew John <[email protected]>
MatthewJohn
force-pushed
the
505-split-output-and-logs
branch
from
d31abbb to
ef79408
Compare
yermulnik
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Perfect. LGTM. Works for me. Though since it's sort of essential change in existing behavior, I'd summon @warrensbox to have him approve it.
warrensbox
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #505