Initial macOS support #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #28 |
|
Thanks a lot @lextm , I don't have experience with Mac but I can provide you access to build system if you want to dig deep and create a build script to generate Mac app bundles. I am using AppVeyor as of now for build automation. Looking forward to hearing from you very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things implemented in this pull request for review,
Avalonia has to be downgraded to 0.9.4. Its 0.9.9 version has miserable crashes when the application is closed. Unless that's fixed, 0.9.4 version is stable to go. Other Avalonia based projects like AvaloniaILSpy also sticks to this version.
All projects are upgraded to .NET Core 3.1. .NET Core 2.2 is end of life, so should not be used any more. Upgrading to 3.1 also allows single file publishing as well as trimming.
Added a few supporting files, so that by running dist.mac.ps1 a macOS bundle ("Jaya.app") can be created. It is the common way to build macOS apps, and projects like MonoDevelop use a similar approach.