feat(keystore-management): membership registration and credentials generation #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danisharora099
force-pushed
the
keystore/registration
branch
from
1d64721 to
f0c0b2a
Compare
danisharora099
force-pushed
the
keystore/registration
branch
from
0e36007 to
f1e6d5a
Compare
danisharora099
changed the title
adklempner
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
UI looks good! I was able to run this locally and successfully register a membership.
out of scope for this PR but instead of displaying the credentials in the app in cleartext, they should be password-encrypted and downloaded as a file (I'm guessing that's next up for you anyways). Something else to consider is determining if the connected wallet address has already registered a credential. If so, it might be worth displaying a warning or a confirmation dialog before registering a new one.
| - **Currency Symbol**: ETH | ||
| - **Block Explorer URL**: https://sepolia.lineascan.build | ||
|
|
||
| You can get Linea Sepolia testnet ETH from the [Linea Faucet](https://faucet.goerli.linea.build/). |
There was a problem hiding this comment.
The link to the faucet doesn't work for me. FWIW I already had Sepolia ETH and was able to bridge using https://bridge.linea.build/
weboko
reviewed
Mar 9, 2025
examples/keystore-management/src/components/RLNMembershipRegistration.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.