Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sds): add retrieval hint to causal history #2299

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adklempner
Copy link
Member

@adklempner adklempner commented Mar 11, 2025

Problem / Description

The protobuf definition for SDS messages was recently update to include a retrieval hint with every message stored in the causal history.

Solution

Update protobuf definition.
Update functions which touch causal history to work with the new structure.
Update the callbacks passed when sending messages to return the retrieval hint.

Notes


Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

Copy link

github-actions bot commented Mar 11, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 85.19 KB (-0.03% 🔽) 1.8 s (-0.03% 🔽) 10 s (+7.69% 🔺) 11.7 s
Waku Simple Light Node 136.25 KB (+0.03% 🔺) 2.8 s (+0.03% 🔺) 13.6 s (+22% 🔺) 16.4 s
ECIES encryption 22.99 KB (+0.32% 🔺) 460 ms (+0.32% 🔺) 3.6 s (-25.82% 🔽) 4 s
Symmetric encryption 22.34 KB (-0.06% 🔽) 447 ms (-0.06% 🔽) 3.9 s (+7.78% 🔺) 4.3 s
DNS discovery 70.94 KB (+0.14% 🔺) 1.5 s (+0.14% 🔺) 9.5 s (-4.45% 🔽) 11 s
Peer Exchange discovery 71.9 KB (+0.07% 🔺) 1.5 s (+0.07% 🔺) 11.5 s (+22.68% 🔺) 12.9 s
Local Peer Cache Discovery 65.56 KB (+0.32% 🔺) 1.4 s (+0.32% 🔺) 8.7 s (+3.95% 🔺) 10.1 s
Privacy preserving protocols 76.78 KB (+0.21% 🔺) 1.6 s (+0.21% 🔺) 8.5 s (+17.86% 🔺) 10.1 s
Waku Filter 78.32 KB (+0.03% 🔺) 1.6 s (+0.03% 🔺) 10 s (+7.87% 🔺) 11.5 s
Waku LightPush 75.74 KB (-0.01% 🔽) 1.6 s (-0.01% 🔽) 7.4 s (-28.24% 🔽) 8.9 s
History retrieval protocols 75.93 KB (+0.09% 🔺) 1.6 s (+0.09% 🔺) 8.9 s (+18.76% 🔺) 10.4 s
Deterministic Message Hashing 7.33 KB (0%) 147 ms (0%) 1.8 s (+1.42% 🔺) 2 s

@adklempner adklempner marked this pull request as ready for review March 11, 2025 22:50
@adklempner adklempner requested a review from a team as a code owner March 11, 2025 22:50
Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no questions to this PR yet
it seems it depends on other PRs, right?

@adklempner
Copy link
Member Author

no questions to this PR yet it seems it depends on other PRs, right?

@weboko Yes this is the last one in the series of 3.

@adklempner adklempner force-pushed the feat/sds-message-history branch from f3effa8 to 23a0dc1 Compare March 13, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sds: Update causal history and local log to include retrieval hint
2 participants