Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial localConfig setup. #30

Merged
merged 14 commits into from
Apr 2, 2024
Merged

Add initial localConfig setup. #30

merged 14 commits into from
Apr 2, 2024

Conversation

aljones15
Copy link
Collaborator

@aljones15 aljones15 commented Mar 28, 2024 •
edited
Loading

This is an untested DRAFT PR, but it theoretically adds support for a localConfig.cjs file

  • Add README docs for this.

@aljones15 aljones15 self-assigned this Mar 28, 2024
@BigBlueHat
Copy link
Member

@aljones15 right now LOCAL_ONLY should be considered deprecated. However...I think we should remove it in favor of this new enableInteropTests option in the localConfig.cjs. The enableInteropTests setting is true by default, unless a localConfig.cjs file exists...at which point it is false (per the new README).

LOCAL_ONLY is now an additional (and now confusingly named) option that overrides the override...so I'd like to remove it, if you have no objections.

aljones15
aljones15 commented Apr 1, 2024
View reviewed changes
README.md Show resolved Hide resolved
aljones15
aljones15 commented Apr 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
aljones15
aljones15 commented Apr 1, 2024
View reviewed changes
README.md Show resolved Hide resolved
aljones15
aljones15 commented Apr 1, 2024
View reviewed changes
README.md Show resolved Hide resolved
aljones15
aljones15 commented Apr 1, 2024
View reviewed changes
lib/main.js Show resolved Hide resolved
@aljones15 aljones15 marked this pull request as ready for review April 1, 2024 20:15
@BigBlueHat BigBlueHat mentioned this pull request Apr 1, 2024
Merged
@BigBlueHat
Rename testAllImplementers to testAllImplementations.
97a894b 
Matches what actually is happening...and what I kept typing...
aljones15
aljones15 commented Apr 2, 2024
View reviewed changes
Copy link
Collaborator Author

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not approve my own PR, but I like the changes and this looks fine to me.

@BigBlueHat BigBlueHat self-requested a review April 2, 2024 19:55
@BigBlueHat BigBlueHat merged commit 83d797a into main Apr 2, 2024
2 checks passed
@BigBlueHat BigBlueHat deleted the use-local-config branch April 2, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tminard tminard tminard approved these changes

@BigBlueHat BigBlueHat BigBlueHat approved these changes

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljones15 @BigBlueHat @tminard